Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm deployment fixes #735

Merged
merged 16 commits into from
Feb 15, 2025
Merged

Helm deployment fixes #735

merged 16 commits into from
Feb 15, 2025

Conversation

downiec
Copy link
Collaborator

@downiec downiec commented Feb 13, 2025

Description

Fixed issues with traefik production deployment. Includes some updates to the management script and updates to the tutorial styling for dark mode.

Fixes: #635

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Zach Price and others added 6 commits February 11, 2025 13:57
…ion, in order to attempt to get production traefik deployment to function as it did in another branch. Updated docker compose files to separate keycloak into a profile and remove docs service from production. Updated manage script to utilize new compose files for deployment and testing.
…update app css and include other minor fixes.
@downiec downiec changed the base branch from master to v1.3.1-release February 13, 2025 04:12
@downiec downiec marked this pull request as ready for review February 13, 2025 04:17
…oid using the conditional statements that were being used which seemed to not be working for traefik deployment. Updated the deployment script to make sure local and production custm overlays are applied last so their variables aren't overriden.
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.3.1-release@0b34d88). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             v1.3.1-release      #735   +/-   ##
==================================================
  Coverage                  ?   100.00%           
==================================================
  Files                     ?        34           
  Lines                     ?      1086           
  Branches                  ?         0           
==================================================
  Hits                      ?      1086           
  Misses                    ?         0           
  Partials                  ?         0           
Flag Coverage Δ
backend 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…deployment container types. Updated the config helper script to generate production overlay
Copy link

@bstrdsmkr bstrdsmkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few comments/questions

backend/config/settings/base.py Outdated Show resolved Hide resolved
backend/config/settings/site_specific.py Show resolved Hide resolved
backend/metagrid/observability/views.py Show resolved Hide resolved
configHelper.sh Show resolved Hide resolved
configHelper.sh Show resolved Hide resolved
docker-compose.prod.yml Outdated Show resolved Hide resolved
docker-compose.prod.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docs/docs/users/compose/moving_to_production.md Outdated Show resolved Hide resolved
… updateProjects.sh script and updated the README's regarding updating project data. Added the update functions to the manage_metagrid.sh scripts instead. Still need to test in production, but should work.
@downiec downiec merged commit 69825a3 into v1.3.1-release Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants