Upgrade amoc_rest with new openapi gens and enforce OTP27 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
openapi_server
branch
2 times, most recently
from
a6c92c2 to
e1ebdaf
Compare
5 tasks
NelsonVides
force-pushed
the
openapi_server
branch
from
e1ebdaf to
cde9151
Compare
NelsonVides
commented
Nov 25, 2024
Comment on lines
+16
to
+17
| get_documentation(Scenario) -> | ||
| case code:get_doc(Scenario) of |
There was a problem hiding this comment.
This is one of my favourite things of upgrading to OTP27, docs are embedded on the module now.
NelsonVides
force-pushed
the
openapi_server
branch
from
cde9151 to
5c9d8a4
Compare
NelsonVides
force-pushed
the
openapi_server
branch
from
5c9d8a4 to
95a4a10
Compare
test/amoc_api_helper.erl
Outdated
| @@ -55,7 +60,8 @@ patch(BaseUrl, Path, Body) -> | |||
|
|
|||
| -spec request(string(), binary(), binary()) -> | |||
| {integer(), json()}. | |||
| request(BaseUrl, Path, Method) -> request(BaseUrl, Path, Method, <<"">>). | |||
| request(BaseUrl, Path, Method) -> | |||
| request(BaseUrl, Path, Method, <<"">>). | |||
There was a problem hiding this comment.
Suggested change
| request(BaseUrl, Path, Method, <<"">>). | |
| request(BaseUrl, Path, Method, <<>>). |
test/amoc_api_helper.erl
Outdated
| @@ -42,11 +45,13 @@ put(BaseUrl, Path, Body) -> | |||
|
|
|||
| -spec patch(string()) -> | |||
| {integer(), json()}. | |||
| patch(Path) -> patch(get_url(), Path, <<"">>). | |||
| patch(Path) -> | |||
| patch(get_url(), Path, <<"">>). | |||
There was a problem hiding this comment.
Suggested change
| patch(get_url(), Path, <<"">>). | |
| patch(get_url(), Path, <<>>). |
NelsonVides
force-pushed
the
openapi_server
branch
from
95a4a10 to
1062fcd
Compare
NelsonVides
force-pushed
the
openapi_server
branch
from
1062fcd to
c6f6fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge after esl/amoc_rest#11
After integrating the new generated code, there's a couple of differences, mostly as we enforce OTP27:
json, we don't need anyjsx/jiffy/other, and it's also the fastest. The generated code also allow us to distinguish between HTTP calls withcontent-type: application/jsonvs others, see the pattern-matching clauses onaccept_callback/4.code:get_doc/1, documentation chunks are now embedded in the module and can be extracted and read at runtime, hence we can rid ofdocsh.