Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect freeaddrinfo call #1755

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix incorrect freeaddrinfo call #1755

merged 1 commit into from
Sep 13, 2024

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Aug 28, 2024 •
edited
Loading

freeaddrinfo call introduced with 111212b is incorrect, because if getaddrinfo failed, there is nothing in there to free.

We encountered segfault there on Solaris, but I can reproduce that on Linux the pointer remains NULL as well when getaddrinfo fails.

@bmah888
Copy link
Contributor

bmah888 commented Aug 30, 2024

Thanks for the PR!

The line of code in question was added in PR #1622.

@bmah888 bmah888 self-assigned this Aug 30, 2024
@bmah888 bmah888 added the bug label Sep 13, 2024
bmah888
bmah888 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, we shouldn't be trying to do freeaddrinfo(NULL).

@bmah888 bmah888 merged commit 62f3fb2 into esnet:master Sep 13, 2024
3 checks passed
@neheb
Copy link
Contributor

neheb commented Nov 20, 2024

Without this, instant crash on musl with

iperf3 -c server -P 4 -t 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmah888 bmah888 bmah888 approved these changes

Assignees

@bmah888 bmah888

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulikjak @bmah888 @neheb