Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about extreme path length limit on Windows #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Timmmm
Copy link

@Timmmm Timmmm commented Mar 13, 2024

This is a very surprising gotcha and kind of a pain to have to regenerate & recompile your project if you didn't know about it. Which you definitely didn't.

This is a very surprising gotcha and kind of a pain to have to regenerate & recompile your project if you didn't know about it. Which you definitely didn't.
@Timmmm
Copy link
Author

Timmmm commented Mar 13, 2024

Actually cancel this. It's literally impossible to have a short enough path on Windows so you cannot use this project on Windows at all.

@SergioGasquez
Copy link
Member

This is already documented in https://docs.esp-rs.org/book/troubleshooting/index.html#long-path-names.

Actually cancel this. It's literally impossible to have a short enough path on Windows so you cannot use this project on Windows at all.

A lot of people use Windows for esp-rs projects, so its possible to workaround this issue.

@Timmmm
Copy link
Author

Timmmm commented Mar 14, 2024

Shouldn't the Troubleshooting section be for issues that might occur? This issue is going to be hit by every Windows user (unless they're extremely lucky) so it makes sense to tell them about it up front rather than let them hit it and have to search for the solution.

However, the check is actually not quite right so it probably makes sense to fix it before updating the documentation. See esp-rs/esp-idf-sys#293

@MabezDev
Copy link
Member

Shouldn't the Troubleshooting section be for issues that might occur?

This is not a problem for WSL users, which may windows users opt to use. So not all windows users are affected.

Making a reference to it early on in the book would be a good idea though, would you mind updating your PR?

@Timmmm
Copy link
Author

Timmmm commented Oct 8, 2024

Hi, sorry for the delay, I'm just coming back to this.

Making a reference to it early on in the book would be a good idea though, would you mind updating your PR?

Might have forgotten the context but I think that's what this PR does already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants