Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package : typos fixed for French language #106

Closed
wants to merge 1 commit into from

Conversation

Jniceid
Copy link

@Jniceid Jniceid commented Mar 22, 2024

Collection of typos fixed for French language

Collection of typos fixed for French language
@Mte90
Copy link
Contributor

Mte90 commented Apr 5, 2024

HI, I already ship a typo fixer also for french on my package (include also other languages) https://github.com/Mte90/espanso-typofixer

Maybe we can join the effort?

@AucaCoyan
Copy link
Member

No response, closing

@AucaCoyan AucaCoyan closed this May 2, 2024
Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few - trigger:/replace: pairs where the two words are the same.

propagate_case: true
word: true
- trigger: pratique
replace: pratique
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these the same?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we can add a lint to check if we have two colliding triggers, that would be nice

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we can add a lint to check if we have two colliding triggers, that would be nice

Well, it's not colliding triggers so much as trigger/replace pairs that don't actually change anything.

propagate_case: true
word: true
- trigger: public
replace: public
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these?
And several others below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants