Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add divination-oracles package #116

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Add divination-oracles package #116

merged 2 commits into from
Jun 1, 2024

Conversation

Metaparadox11
Copy link
Contributor

Created a package of random oracles used for divination or gaming (playing cards, tarot, Lenormand, runes).

@Metaparadox11
Added my package
b19fcfb 
Added Divination Oracles package
smeech
smeech reviewed May 26, 2024
View reviewed changes
Copy link
Collaborator

@smeech smeech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward text expansion package making good use of Espanso's random type and interesting use of blank choices to determine probability.
No cmd, script or malicious code.
Looks safe to merge with a couple of suggestions.

packages/divination-oracles/0.1.0/_manifest.yml Outdated Show resolved Hide resolved
packages/divination-oracles/0.1.0/package.yml Outdated Show resolved Hide resolved
@Metaparadox11
Suggested changes made
d41f97c 
As suggested in pull request comments
@smeech
Copy link
Collaborator

smeech commented Jun 1, 2024

Thank you.

@smeech smeech merged commit 1397e72 into espanso:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeech smeech smeech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Metaparadox11 @smeech