Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dummy_phy): created a dummy PHY instace for direct EMAC to EMAC #21

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat(dummy_phy): created a dummy PHY instace for direct EMAC to EMAC #21

merged 1 commit into from
Jul 10, 2024

Conversation

kostaond
Copy link
Collaborator

The Dummy PHY component enables a direct EMAC to EMAC communication between two Ethernet capable devices without usage of external PHY transceiver. The design idea is to provide EMAC to EMAC connection between two devices without any modification to ESP-IDF Ethernet driver.

@kostaond kostaond self-assigned this Feb 29, 2024
@kostaond kostaond mentioned this pull request Mar 25, 2024
Open
@kostaond
Copy link
Collaborator Author

@suda-morris PTAL

suda-morris
suda-morris approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@suda-morris suda-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting feature! LGTM

david-cermak
david-cermak approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for providing this functionality!

@kostaond kostaond force-pushed the feature/emac2emac branch 3 times, most recently from 2ccf1fe to 8d8f8d7 Compare July 10, 2024 20:30
@kostaond kostaond force-pushed the feature/emac2emac branch from 8d8f8d7 to 470eca1 Compare July 10, 2024 20:48
@kostaond kostaond merged commit 1d1e3cb into master Jul 10, 2024
19 checks passed
@kostaond kostaond deleted the feature/emac2emac branch July 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankolendovskyy bogdankolendovskyy bogdankolendovskyy left review comments

@david-cermak david-cermak david-cermak approved these changes

@suda-morris suda-morris suda-morris approved these changes

@espressif-abhikroy espressif-abhikroy Awaiting requested review from espressif-abhikroy

Assignees

@kostaond kostaond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kostaond @suda-morris @david-cermak @bogdankolendovskyy