feat(common_examples): Add common examples aplicable for all phys #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
from
56ee482 to
741cd12
Compare
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
4 times, most recently
from
b8d4389 to
65b4dc4
Compare
kostaond
reviewed
Apr 17, 2024
|
@bogdankolendovskyy general comment, I'm missing README's for examples. |
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
from
65b4dc4 to
d299f03
Compare
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
2 times, most recently
from
f0887aa to
6eb59f8
Compare
kostaond
reviewed
Apr 22, 2024
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
4 times, most recently
from
c9a4619 to
738fdbb
Compare
kostaond
reviewed
Apr 29, 2024
kostaond
reviewed
Apr 29, 2024
kostaond
reviewed
Apr 29, 2024
kostaond
reviewed
Apr 29, 2024
kostaond
reviewed
Apr 29, 2024
kostaond
reviewed
Apr 29, 2024
kostaond
reviewed
Apr 30, 2024
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
2 times, most recently
from
1ea002e to
6aaff3e
Compare
kostaond
reviewed
May 2, 2024
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
from
6aaff3e to
1a9b41e
Compare
|
Note to self: update iperf to support multiple subnets after finalizing the code in tcp_server. |
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
4 times, most recently
from
ca7e7ed to
6badbe0
Compare
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
from
6badbe0 to
1babe1b
Compare
There was a problem hiding this comment.
Good work @bogdankolendovskyy
just left few formal comments and suggestions.
One general nitpick would be to:
- correct newlines at the end of all files
- add copyright messages to headers and sources
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
2 times, most recently
from
9aa9eed to
538712e
Compare
bogdankolendovskyy
force-pushed
the
universal-examples-master
branch
from
538712e to
c09c4d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add common examples which are implemented for all phys (
simple_ethernetinitialization example,iperf, andtcp_client,tcp_server)simple_ethernet
simple_ethernetdemonstrates initialization usingethernet_initcomponent. Moved fromethernet_init/examplestocommon_examples/to keep all universal examples in the same directory.iperf
iperf 3 example with support of dhcp server, allowing not only "ESP32 to PC" connection, but "ESP32 to ESP32" connection as well.
tcp_client and tcp_server
TCP socket client which is able to send periodic transmissions and server responding to it. Both are bundled with python scripts to be ran on PC side.