Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected typo from disbale to disable in numerous places (IDFGH-11298) #12451

Conversation

DevinNorgarb
Copy link
Contributor

Just a few corrections of the typo disbale to disable

Thanks for your consideration

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.

👋 Welcome DevinNorgarb, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against ab6025a

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 23, 2023
@github-actions github-actions bot changed the title fix: corrected typo from disbale to disable in numerous places fix: corrected typo from disbale to disable in numerous places (IDFGH-11298) Oct 23, 2023
@espressif-bot espressif-bot assigned Isl2017 and esp-zhp and unassigned Isl2017 Oct 24, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Oct 24, 2023
@DevinNorgarb
Copy link
Contributor Author

Hi @zhp0406, the build steps say the build is failing due to not having committed using the pre-commit tool.
However, I installed and ensured my commits complied with the pre-commit rules before pushing.
Is there any further action required from my side?
Thanks in advance.
image


@esp-zhp
Copy link
Collaborator

esp-zhp commented Oct 27, 2023

@DevinNorgarb
I will help you through the pipeline and submit your code.

@DevinNorgarb
Copy link
Contributor Author

@zhp0406 Thank you!
If there is anything further you need from me please let me know.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress labels Oct 31, 2023
@esp-zhp
Copy link
Collaborator

esp-zhp commented Nov 8, 2023

@DevinNorgarb
Thank you for your fix, now the commit(001b10ec4592881419b5672de5329add13618a48) is visible. If there are no other issues, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants