Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for ESP-IDF versions below 5.2 (IDFGH-11800) #12895

Closed
wants to merge 1 commit into from

Conversation

Augtons
Copy link
Contributor

@Augtons Augtons commented Dec 29, 2023

In ESP-IDF 5.2, littlefs became a valid sub-type for the partition table, with the value of 0x83, and this example uses it. However, before that, this sub-type was not recognized by default. Therefore, I updated the CMakeLists.txt file to set it as a custom sub-type for ESP-IDF versions lower than 5.2, in order to make this example compatible with older ESP-IDF versions.

Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Augtons, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against e6767bb

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 29, 2023
@github-actions github-actions bot changed the title feat: Add support for ESP-IDF versions below 5.2 feat: Add support for ESP-IDF versions below 5.2 (IDFGH-11800) Dec 29, 2023
@Augtons
Copy link
Contributor Author

Augtons commented Dec 30, 2023

It looks like some checks didn't pass, I'm trying to install pre-commit and I'll start PR again when everything goes well!

@Augtons Augtons closed this Dec 30, 2023
@Augtons
Copy link
Contributor Author

Augtons commented Dec 30, 2023

It looks like some checks didn't pass, I'm trying to install pre-commit and I'll start PR again when everything goes well!

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: Duplicate This issue or pull request already exists and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate This issue or pull request already exists Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants