-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make examples/storage/littlefs support for ESP-IDF versions below 5.2 (IDFGH-11806) #12901
Conversation
👋 Hello Augtons, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi, thank you for contribution. Changes look good to me except for changes in |
Yes, the pre-commit tool automatically added this annoying change for me. I tried to delete it that day, but it would still be automatically added after deletion. Next, I will try to pull origin/master and rebase it to the latest master, hope everything goes well. Thank you! |
8e02ee7
to
d68b3c3
Compare
Hi, @adokitkat. I updated my commit, removed the changes of annoying tools/ci/check_public_headers_exceptions.txt and used git rebase to make my commit history look clear. It has passed the test now. |
sha=d68b3c3b2f2e97d0b9ea7a182914e13d3d47605a |
Hi @Augtons. Once again thank you for the contribution. After some consideration we decided it would be better to just backport LittleFS example with appropriate commits instead of merging this PR, which is a kind of work-around. I am sorry about this. I have created the backports for release/v5.0 and release/v5.1 branches (however there is one blocker issue for v5.0 branch right now so it needs to wait for another MR right now). |
littlefs example is now present in IDF v5.0 and newer. |
In ESP-IDF 5.2, littlefs became a valid sub-type for the partition table, with the value of
0x83
, and this example uses it. However, before that, this sub-type was not recognized by default. Therefore, I updated theCMakeLists.txt
file to set it as a custom sub-type for ESP-IDF versions lower than 5.2, in order to make this example compatible with older ESP-IDF versions.