Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make examples/storage/littlefs support for ESP-IDF versions below 5.2 (IDFGH-11806) #12901

Closed
wants to merge 1 commit into from

Conversation

Augtons
Copy link
Contributor

@Augtons Augtons commented Dec 30, 2023

In ESP-IDF 5.2, littlefs became a valid sub-type for the partition table, with the value of 0x83, and this example uses it. However, before that, this sub-type was not recognized by default. Therefore, I updated the CMakeLists.txt file to set it as a custom sub-type for ESP-IDF versions lower than 5.2, in order to make this example compatible with older ESP-IDF versions.

Copy link

github-actions bot commented Dec 30, 2023

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Augtons, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against d68b3c3

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 30, 2023
@github-actions github-actions bot changed the title Make examples/storage/littlefs support for ESP-IDF versions below 5.2 Make examples/storage/littlefs support for ESP-IDF versions below 5.2 (IDFGH-11806) Dec 30, 2023
@adokitkat
Copy link
Collaborator

adokitkat commented Jan 3, 2024

Hi, thank you for contribution. Changes look good to me except for changes in tools/ci/check_public_headers_exceptions.txt file - are those necessary to pass tests? Please try to remove them from your commit, then checkout to and pull latest master branch and rebase this branch to origin/master.

@Augtons
Copy link
Contributor Author

Augtons commented Jan 4, 2024

Yes, the pre-commit tool automatically added this annoying change for me. I tried to delete it that day, but it would still be automatically added after deletion. Next, I will try to pull origin/master and rebase it to the latest master, hope everything goes well. Thank you!

@Augtons
Copy link
Contributor Author

Augtons commented Jan 4, 2024

Hi, @adokitkat. I updated my commit, removed the changes of annoying tools/ci/check_public_headers_exceptions.txt and used git rebase to make my commit history look clear. It has passed the test now.

@adokitkat
Copy link
Collaborator

sha=d68b3c3b2f2e97d0b9ea7a182914e13d3d47605a

@adokitkat adokitkat added the PR-Sync-Merge Pull request sync as merge commit label Jan 4, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Jan 5, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: In Progress Work is in progress and removed Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Jan 15, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: In Progress Work is in progress labels Jan 22, 2024
@adokitkat
Copy link
Collaborator

adokitkat commented Jan 29, 2024

Hi @Augtons. Once again thank you for the contribution. After some consideration we decided it would be better to just backport LittleFS example with appropriate commits instead of merging this PR, which is a kind of work-around. I am sorry about this. I have created the backports for release/v5.0 and release/v5.1 branches (however there is one blocker issue for v5.0 branch right now so it needs to wait for another MR right now).

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Mar 4, 2024
@adokitkat adokitkat closed this Oct 9, 2024
@adokitkat
Copy link
Collaborator

littlefs example is now present in IDF v5.0 and newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants