Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APB_CLK_FREQ value for C6 (IDFGH-11886) #12972

Closed
wants to merge 1 commit into from
Closed

Fix APB_CLK_FREQ value for C6 (IDFGH-11886) #12972

wants to merge 1 commit into from

Conversation

majkrzak
Copy link

This PR changes previously wrong value of APB_CLK_FREQ. It solves the issue with RMT LED driver where pulse with where incorrectly calculated using 40 MHz instead of 80 MHz clock base.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jan 14, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello majkrzak, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 212cd9b

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 14, 2024
@github-actions github-actions bot changed the title Fix APB_CLK_FREQ value for C6 Fix APB_CLK_FREQ value for C6 (IDFGH-11886) Jan 14, 2024
@suda-morris
Copy link
Collaborator

Hi @majkrzak

The APB clock frequency is true to be 40MHz, but just on esp32c6, the APB clock can not work as a function clock for the RMT. Instead, the supported clock sources are listed here It has a PLL clock source whose frequency is 80MHz, but it's not APB anymore.

If you wants to write some code to work cross the esp chips, you can set the RMT clock source to RMT_CLK_SRC_DEFAULT. Like this

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Opened Issue is new labels Jan 15, 2024
@majkrzak
Copy link
Author

majkrzak commented Jan 15, 2024

Ok thank you. This mean ESP-idf documentation is wrong. It claims RMT is clocked with APB clock with default frequency of 80MHz. And we had wrongly used the ABP_CLK_DIV macro to provide proper value. I believe there is none congaing the proper value for the RMT clock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants