-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filename, linenumber and function name to log statements (IDFGH-12023) #13088
Add filename, linenumber and function name to log statements (IDFGH-12023) #13088
Conversation
👋 Hello 0xFEEDC0DE64, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
51628c6
to
52cc87b
Compare
It is not just binary size. Currently all logging is synchronous which means the extra information makes logging slower and in turn has performance impacts on all firmwares. |
52cc87b
to
04c462f
Compare
I wrote a variant of this for a project at work, but didn't even consider upstreaming because @jrahlf is right. |
Hi! I am working on esp log v2 which will make the log more flexible and functional. Sorry, we will not merge this PR, thank you for your contribution. |
This merge request adds filenames, linenumbers and function names to all log statements.
Very often I am in a situation where a esp component logs some sort of warning or error and I need to check the exact conditions how they can appear, and I would like to jump to that exact code line, where this log statement occurs.
The old if logging style only contains the tag and the message, which is just not enough to pinpoint the log line for me.
In the past I have gotten the feedback that the binary size might increase significantly. If you want I will provide another commit that only turns on this additional log functionality when its not inside the bootloader + a Kconfig parameter. Let me know what you think.