Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(esp_system,ulp): LP core reserved mem optionally executable from HP core (IDFGH-13533) #14422

Closed
wants to merge 1 commit into from
Closed

feat(esp_system,ulp): LP core reserved mem optionally executable from HP core (IDFGH-13533) #14422

wants to merge 1 commit into from

Conversation

andylinpersonal
Copy link
Contributor

Make LP core reserved memory optionally executable in HP core. Currently its locked to RW in PMP.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello andylinpersonal, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 1ac21bd

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 22, 2024
@github-actions github-actions bot changed the title feat(esp_system,ulp): LP core reserved mem optionally executable in HP core feat(esp_system,ulp): LP core reserved mem optionally executable in HP core (IDFGH-13533) Aug 22, 2024
atanisoft
atanisoft reviewed Aug 22, 2024
View reviewed changes
components/esp_system/Kconfig Outdated
depends on IDF_TARGET_ARCH_RISCV && SOC_LP_CORE_SUPPORTED && ESP_SYSTEM_PMP_IDRAM_SPLIT
default "n"
help
If enabled, user can run code only available in LP Core image.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing only in this sentence since the current wording reads as only the LP memory would be usable which is not necessarily how the code is above.

@andylinpersonal andylinpersonal force-pushed the dev/v5.4-lp_ram_executable branch from 1e5038d to 52aaaab Compare August 22, 2024 16:32
@mahavirj mahavirj requested a review from ESP-Marius August 23, 2024 07:23
ESP-Marius
ESP-Marius reviewed Aug 26, 2024
View reviewed changes
components/esp_hw_support/port/esp32c61/cpu_region_protect.c Outdated
@@ -153,7 +153,11 @@ void esp_cpu_configure_region_protection(void)
PMP_ENTRY_SET(10, SOC_RTC_IRAM_LOW, NONE);
#if CONFIG_ULP_COPROC_RESERVE_MEM
// First part of LP mem is reserved for coprocessor
#if CONFIG_ESP_SYSTEM_PMP_LP_CORE_RESERVE_MEM_EXECUTABLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can drop this since C61 does not have an ulp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused ESP32-C61 code has been removed, thanks!

ESP-Marius
ESP-Marius reviewed Aug 26, 2024
View reviewed changes
components/esp_system/Kconfig Outdated
@@ -138,6 +138,13 @@ menu "ESP System Settings"
for the data part (above the splitting address). The memory protection is effective
on all access through the IRAM0 and DRAM0 buses.

config ESP_SYSTEM_PMP_LP_CORE_RESERVE_MEM_EXECUTABLE
bool "Make LP core reserved memory executable in HP core"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, should it be

Suggested change
bool "Make LP core reserved memory executable in HP core"
bool "Make LP core reserved memory executable from HP core"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixed, thanks!

@ESP-Marius
Copy link
Collaborator

@andylinpersonal Thanks! I don't see any issues in adding this functionality, left some minor nitpicks.

@andylinpersonal andylinpersonal force-pushed the dev/v5.4-lp_ram_executable branch from 52aaaab to 1ac21bd Compare August 26, 2024 10:34
@andylinpersonal andylinpersonal changed the title feat(esp_system,ulp): LP core reserved mem optionally executable in HP core (IDFGH-13533) feat(esp_system,ulp): LP core reserved mem optionally executable from HP core (IDFGH-13533) Aug 26, 2024
@ESP-Marius
Copy link
Collaborator

sha=1ac21bd27387f013a5d758f42077eed3e55b5588

@ESP-Marius ESP-Marius added the PR-Sync-Merge Pull request sync as merge commit label Aug 28, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new labels Aug 28, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Reviewing Issue is being reviewed labels Sep 12, 2024
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 5486653.

@Alvin1Zhang Alvin1Zhang closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ESP-Marius ESP-Marius ESP-Marius left review comments

@atanisoft atanisoft atanisoft left review comments

Assignees

@ESP-Marius ESP-Marius

Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andylinpersonal @ESP-Marius @Alvin1Zhang @atanisoft @espressif-bot