Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: S3: configure external oscillator correctly (IDFGH-13553) #14442

Closed
wants to merge 1 commit into from

Conversation

2opremio
Copy link

Addresses part of #10269

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 26, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello 2opremio, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 4c083df

@2opremio 2opremio changed the title feat: S3: configure external oscillator correctly fix: S3: configure external oscillator correctly Aug 26, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 26, 2024
@github-actions github-actions bot changed the title fix: S3: configure external oscillator correctly fix: S3: configure external oscillator correctly (IDFGH-13553) Aug 26, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Sep 4, 2024
@songruo
Copy link
Collaborator

songruo commented Sep 9, 2024

@2opremio We have fixed the issue in b9c58c5. Please check if you can use external oscillator on current master now. I will close the PR, if it is still a problem, feel free to reopen or create a new issue.

@songruo songruo closed this Sep 9, 2024
@2opremio
Copy link
Author

2opremio commented Sep 9, 2024

The PR doesn’t seem to set the right buf value for the external oscillator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants