fix(spinlock): comparison of integer expressions of different signedness (IDFGH-13581) #14469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developers who do not use idf.py but prefer classic CMake currently receive a lot of warnings because a comparison in the header file
spinlock.h
is not correct.comparison of integer expressions of different signedness: 'esp_cpu_cycle_count_t' {aka 'long unsigned int'} and 'int32_t' {aka 'long int'} [-Wsign-compare]
since it is a header, the gcc option
-Wall
, which is relevant for the application code, unfortunately also applies to all includes.this fix casts the signed
timeout
to the corresponding unsigned typeesp_cpu_cycle_count_t
for a correct comparison.