Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spinlock): comparison of integer expressions of different signedness (IDFGH-13581) #14469

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

Andste82
Copy link
Contributor

developers who do not use idf.py but prefer classic CMake currently receive a lot of warnings because a comparison in the header file spinlock.h is not correct.

comparison of integer expressions of different signedness: 'esp_cpu_cycle_count_t' {aka 'long unsigned int'} and 'int32_t' {aka 'long int'} [-Wsign-compare]

since it is a header, the gcc option -Wall, which is relevant for the application code, unfortunately also applies to all includes.

this fix casts the signed timeout to the corresponding unsigned type esp_cpu_cycle_count_t for a correct comparison.

Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Andste82, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 681b372

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 30, 2024
@github-actions github-actions bot changed the title fix(spinlock): comparison of integer expressions of different signedness fix(spinlock): comparison of integer expressions of different signedness (IDFGH-13581) Aug 30, 2024
@KonstantinKondrashov
Copy link
Collaborator

sha=681b37266861b2f3d35e50d43b146691cdfe7281

@KonstantinKondrashov KonstantinKondrashov added the PR-Sync-Merge Pull request sync as merge commit label Sep 3, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Sep 14, 2024
@espressif-bot espressif-bot merged commit 1489514 into espressif:master Sep 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants