Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESP32 TinyS3 (IDFGH-13594) #14481

Closed
wants to merge 1 commit into from
Closed

Conversation

zoonman
Copy link

@zoonman zoonman commented Sep 2, 2024

In ESP32 TinyS3 LED is powered by pin IO17 and controlled by IO18.

Current example doesn't work out of the box for those boards because IO17 is low. We need to supply power in order to control WS2812B.

See schematic https://github.com/UnexpectedMaker/esp32s3/blob/main/schematics/schematic-tinys3.pdf

This board is very popular amongst beginners and proposed change will significantly ease learning curve.

In ESP32TinyS3 LED is powered by pin IO17 and controlled by IO18.
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Sep 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Support ESP32TinyS3":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello zoonman, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against cb4269d

@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 2, 2024
@github-actions github-actions bot changed the title Support ESP32 TinyS3 Support ESP32 TinyS3 (IDFGH-13594) Sep 2, 2024
@suda-morris
Copy link
Collaborator

@zoonman Thanks for your contribution to esp-idf. It's nice to see a 🆕 ESP32-S3 board.

In ESP32 TinyS3 LED is powered by pin IO17

This looks dangerous, as usual, we don't recommend connecting a GPIO to a device's VDD, becuase GPIO has limited current output ability.

Current example doesn't work out of the box for those boards because IO17 is low.

Unfortunately, this is a common "issue" for esp-idf examples, that it can't work out of the box on many boards, because it doesn't have the idea of "what board is running with". "Set the GPIO17" may benefit for your board, but may cause problem for other boards.

Since this is a famous board, I would suggest making a BSP package for it. You can find many existing BSP packages here.

@zoonman
Copy link
Author

zoonman commented Sep 2, 2024

Hi @suda-morris . I think making BSP package is slightly above my commitment plan.

I think it would be worth for @UnexpectedMaker to look into something like that.

@zoonman
Copy link
Author

zoonman commented Sep 10, 2024

I am closing this one. I hope @UnexpectedMaker will look into BSP package option. I honestly don't have time for that.

@suda-morris thank you for replying and explanation. I truly appreciate that.

@zoonman zoonman closed this Sep 10, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Opened Issue is new labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants