-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(esp-tls): add option to enable/disable the full set of OCSP checks for wolfSSL (IDFGH-13619) #14503
Conversation
👋 Hello frankencode, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
components/esp-tls/Kconfig
Outdated
@@ -115,4 +115,12 @@ menu "ESP-TLS" | |||
help | |||
Enable detailed debug prints for wolfSSL SSL library. | |||
|
|||
config ESP_WOLFSSL_OCSP_CHECKALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move this config option to esp-wolfssl
component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I can do so. The reason it is here is because it currently affects only esp-tls in its behavior of enabling OCSP on the TLS session through certain optional wolfSSL library calls. It won't affect the wolfSSL component itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was first confused with the name being ESP_WOLFSSL.
Maybe it would be better to change this config option as ESP_TLS_OCSP_CHECKALL
Other things can remain the same
@frankencode Thanks for the change. |
OK, I've fixed that Kconfig to proper "ESP_TLS_" prefix. |
Done. |
sha=ba27281c3ed7c3ee174db5bd75f4dc7cd698c241 |
I've added an option to enable/disable WOLFSSL_OCSP_CHECKALL when enabling OCSP in esp_tls_wolfssl.c .