feat(ethernet/ptp): added support for gPTP (IDFGH-14203)

[scrambletools]

This includes handling peer delay messages and TLVs in announce and follow up messages. Also, handles simpler BMCA in gPTP case. Currently it seems the HW timestamp is not showing in the IREC in the case of received frames, so that made it difficult to test interop with other gPTP devices.

Tested with MOTU AVB Switch as well as Apple Mac desktop. Hoping to see a fix for the HW timestamp issue, assuming I'm not missing something.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "Added support for gPTP": body's lines must not be longer than 100 characters summary looks empty type/action looks empty the commit message "feat(ethernet/ptp): sending peer delay req and processing respons/followup": body's lines must not be longer than 100 characters Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello scrambletools, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 104d9d5

[scrambletools]

Next commit will handle receiving peer delay response and response follow up messages for gPTP case. Currently only supports processing gPTP peer delay requests and sending correct response and response follow up.

[kostaond]

Hi @scrambletools, thanks for the update! The current PTP implementation really misses the P2P mode. So it's great you've had a look into it. However, our PTP is currently not fully stable so I cannot give you any time frame when your PR could be merged. I need to stabilize the API at first.

Luckily it doesn't mean you to stop your effort! Please try to update emac_hal_ptp_start function, add emac_ll_ts_ptp_snap_type_sel(hal->ptp_regs, 1); and you should be able to receive Pdelay messages (MAC addr 01:80:C2:00:00:0E) via IREC. Please let me know if it worked.

[scrambletools]

I'll take a look, thanks!

…

On Mon, Dec 9, 2024 at 12:34 AM Ondrej Kosta ***@***.***> wrote: Hi @scrambletools <https://github.com/scrambletools>, thanks for the update! The current PTP implementation really misses the P2P mode. So it's great you've had a look into it. However, our PTP is currently not fully stable so I cannot give you any time frame when your PR could be merged. I need to stabilize the API at first. Luckily it doesn't mean you to stop your effort! Please try to update emac_hal_ptp_start function, add emac_ll_ts_ptp_snap_type_sel(hal->ptp_regs, 1); and you should be able to receive Pdelay messages via IREC. Please let me know if it worked. — Reply to this email directly, view it on GitHub <#15001 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BGW4UN5YFGROOWWLY2TE5C32EVIYZAVCNFSM6AAAAABTHZ7CPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGI3DEMRUGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[scrambletools]

It seems to have worked! Thanks. I'll keep testing...