Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): Compiler reports some warnings (IDFGH-14275) #15068

Closed
wants to merge 1 commit into from
Closed

fix(components): Compiler reports some warnings (IDFGH-14275) #15068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions components/driver/twai/twai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,7 @@ esp_err_t twai_driver_install_v2(const twai_general_config_t *g_config, const tw
.clock_source_hz = clock_source_hz,
.controller_id = controller_id,
};
bool res = twai_hal_init(&p_twai_obj->hal, &hal_config);
assert(res);
assert(twai_hal_init(&p_twai_obj->hal, &hal_config));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If assert is disabled, the function called inside the assert will not be invoked. (it is an expected behavior of assert).

Then the twai driver missed an important initialization.

twai_hal_configure(&p_twai_obj->hal, t_config, f_config, DRIVER_DEFAULT_INTERRUPTS, g_config->clkout_divider);

//Assign GPIO and Interrupts
Expand Down
3 changes: 1 addition & 2 deletions components/fatfs/diskio/diskio_rawflash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,8 @@ DRESULT ff_raw_write (BYTE pdrv, const BYTE *buff, DWORD sector, UINT count)

DRESULT ff_raw_ioctl (BYTE pdrv, BYTE cmd, void *buff)
{
const esp_partition_t* part = s_ff_raw_handles[pdrv];
ESP_LOGV(TAG, "ff_raw_ioctl: cmd=%in", cmd);
assert(part);
assert(s_ff_raw_handles[pdrv]);
switch (cmd) {
case CTRL_SYNC:
return RES_OK;
Expand Down
3 changes: 1 addition & 2 deletions components/fatfs/vfs/vfs_fat_sdmmc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,7 @@ esp_err_t esp_vfs_fat_sdcard_format_cfg(const char *base_path, sdmmc_card_t *car

//format
uint32_t id = FF_VOLUMES;
bool found = s_get_context_id_by_card(card, &id);
assert(found);
assert(s_get_context_id_by_card(card, &id));

if (cfg) {
s_ctx[id]->mount_config = *cfg;
Expand Down
Loading