-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docs/icpm_echo): Added requires libraries to the code example so that it doesn't throw undeclared error (IDFGH-14318) #15110
base: master
Are you sure you want to change the base?
Conversation
Added libs so that the code example works. It didn't work because of missing declarations: struct addrinfo getaddrinfo()
👋 Hello b0tFilip, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help and contribution!
could you please address the formal issues with
- you commit message as mentioned here?
- make the same changes also the CN docs in
docs/zh_CN/api-reference/protocols/icmp_echo.rst
?
Added libraries so that the code example doesn't throw errors about undeclared struct and function.
It didn't work because of missing declarations:
struct addrinfo
getaddrinfo()
It's just a small detail but it cost me an hour of debuging to find these libs that fix it.