fix(modem): Fix vfs terminal not to reset read_cb() automatically

This change is needed for the fs terminal to work correctly again, after merging 44bae24 which shifted responsibility of thread safety from a terminal to the DTE. (Before it was the terminal, which removed this callback safely when processing completed, and thus we had to check the callback return value). Not the DTE layers are responsible for thread safety and the return value indicates success/failure from processing. Also uses the default clock, the same way as UART terminal.
espressif · Sep 20, 2023 · 25a35e2 · 25a35e2
1 parent 12bacdc
commit 25a35e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/components/esp_modem/include/vfs_resource/vfs_create.hpp b/components/esp_modem/include/vfs_resource/vfs_create.hpp
@@ -14,7 +14,7 @@
             .stop_bits = UART_STOP_BITS_1,          \
             .parity = UART_PARITY_DISABLE,          \
             .flow_control = ESP_MODEM_FLOW_CONTROL_NONE,\
-            .source_clk = UART_SCLK_APB,            \
+            .source_clk = ESP_MODEM_DEFAULT_UART_CLK,   \
             .baud_rate = 115200,                    \
             .tx_io_num = 25,                        \
             .rx_io_num = 26,                        \

diff --git a/components/esp_modem/src/esp_modem_term_fs.cpp b/components/esp_modem/src/esp_modem_term_fs.cpp
@@ -122,9 +122,7 @@ void FdTerminal::task()
         } else {
             if (FD_ISSET(f.fd, &rfds)) {
                 if (on_read_priv) {
-                    if (on_read_priv(nullptr, 0)) {
-                        on_read_priv = nullptr;
-                    }
+                    on_read_priv(nullptr, 0);
                 }
             }
         }