nicer comment. (IDFGH-9963) #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Thanks for the updates, changes LGTM. But please create a nicer commit message.
We've just merged support for conventional commits in this repo, so please rebase and install the precommit hook and have the tooling help you with writing nicely structured commit messages. Thanks!
|
|
david-cermak
pushed a commit
to david-cermak/esp-protocols
that referenced
this pull request
Mar 18, 2024
|
Thanks for the contribution, we'll accept this via #531 |
david-cermak
pushed a commit
to david-cermak/esp-protocols
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nicer comment.
copied from SIM7070_SIM7080_SIM7090%20Series_AT%20Command%20Manual_V1.05.pdf