fix(modem): Update vfs terminal; Removed designated init #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed for the fs terminal to work correctly again, after merging 44bae24 which shifted responsibility of thread safety from a terminal to the DTE. (Before it was the terminal, which removed this callback safely when processing completed, and thus we had to check the callback return value). Not the DTE layers are responsible for thread safety and the return value indicates success/failure from processing. Also uses the default clock, the same way as UART terminal.
If the config struct contains more items (or more items will be added in future) this init will not compile cleanly
david-cermak
force-pushed
the
fix/modem_cosmetic
branch
from
7bba2b9 to
5287432
Compare
euripedesrocha
approved these changes
Sep 22, 2023
|
|
|
Thanks for the review Euripedes, I'd have to add one commit by @suren-gabrielyan-espressif to pass the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix netif to set PPP config in C++ way
Fix netif to set PPP config in C++ way