Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): Added simple component for console initialization #372

Conversation

espressif-abhikroy
Copy link
Collaborator

The component provides a simple api's to initialize and start the esp console.
It also provides an api to register an user provided command.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but missing the github action that would publish this component

@espressif-abhikroy espressif-abhikroy force-pushed the components/console_simple_init branch from 7207dbe to a4a0a2c Compare October 9, 2023 11:58
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-abhikroy espressif-abhikroy force-pushed the components/console_simple_init branch from a4a0a2c to 15a683b Compare October 9, 2023 12:24
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_simple_init branch 2 times, most recently from 5b3e7cd to 88c3b37 Compare October 9, 2023 12:52
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@espressif-abhikroy espressif-abhikroy force-pushed the components/console_simple_init branch 3 times, most recently from 48092d1 to 5f3ef20 Compare October 10, 2023 12:34
@espressif-abhikroy espressif-abhikroy force-pushed the components/console_simple_init branch from 5f3ef20 to 1ac4e41 Compare October 10, 2023 12:46
@david-cermak david-cermak merged commit 93dd567 into espressif:master Oct 10, 2023
20 checks passed
@espressif-abhikroy espressif-abhikroy deleted the components/console_simple_init branch October 10, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants