-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): Added simple component for console initialization #372
Merged
david-cermak
merged 1 commit into
espressif:master
from
espressif-abhikroy:components/console_simple_init
Oct 10, 2023
Merged
feat(common): Added simple component for console initialization #372
david-cermak
merged 1 commit into
espressif:master
from
espressif-abhikroy:components/console_simple_init
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espressif-abhikroy
requested review from
david-cermak,
euripedesrocha and
igrr
October 9, 2023 11:42
david-cermak
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but missing the github action that would publish this component
espressif-abhikroy
force-pushed
the
components/console_simple_init
branch
from
October 9, 2023 11:58
7207dbe
to
a4a0a2c
Compare
espressif-abhikroy
force-pushed
the
components/console_simple_init
branch
from
October 9, 2023 12:24
a4a0a2c
to
15a683b
Compare
espressif-abhikroy
force-pushed
the
components/console_simple_init
branch
2 times, most recently
from
October 9, 2023 12:52
5b3e7cd
to
88c3b37
Compare
david-cermak
reviewed
Oct 9, 2023
david-cermak
reviewed
Oct 9, 2023
components/console_simple_init/examples/console_init-basic/main/CMakeLists.txt
Outdated
Show resolved
Hide resolved
david-cermak
reviewed
Oct 9, 2023
components/console_simple_init/examples/console_init-basic/pytest_console_init-basic.py
Outdated
Show resolved
Hide resolved
david-cermak
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
espressif-abhikroy
force-pushed
the
components/console_simple_init
branch
3 times, most recently
from
October 10, 2023 12:34
48092d1
to
5f3ef20
Compare
espressif-abhikroy
force-pushed
the
components/console_simple_init
branch
from
October 10, 2023 12:46
5f3ef20
to
1ac4e41
Compare
david-cermak
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component provides a simple api's to initialize and start the esp console.
It also provides an api to register an user provided command.