feat(console): Added ping command to console component #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espressif-abhikroy
force-pushed
the
components/console_cmd_ping
branch
from
1a03000 to
0bcf1fd
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ping
branch
2 times, most recently
from
2bb4359 to
cabb1e1
Compare
igrr
reviewed
Oct 23, 2023
espressif-abhikroy
force-pushed
the
components/console_cmd_ping
branch
4 times, most recently
from
e4f3e2b to
ffba02b
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ping
branch
2 times, most recently
from
0126b60 to
2e6c361
Compare
|
@espressif-abhikroy Please resolve the addressed discussion, rebase and get the CI pass. |
espressif-abhikroy
force-pushed
the
components/console_cmd_ping
branch
from
2e6c361 to
3f8398a
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ping
branch
from
3f8398a to
7babdeb
Compare
david-cermak
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component provides a console where the 'ping' command can be executed.