-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modem): Fixed mode transitions between any state and UNDEF #416
fix(modem): Fixed mode transitions between any state and UNDEF #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few minor comments.
07aad36
to
5396de4
Compare
Doesn't seem to fully work as intended with SIM7600. Test case: dce->set_mode(esp_modem::modem_mode::CMUX_MODE); // OK esp_modem starts to send +++ and AT wrapped: and doesn't recognize the unwrapped response by the modem: |
That's not how the What you describe in your test case is more like a situation suitable for mode detection (another planned feature), in other words: We don't know what state the modem is in, so we check how it responds to all protocols and set the mode accordingly. |
Closes #320