Add override_path in example manifests #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euripedesrocha
approved these changes
Nov 9, 2023
david-cermak
force-pushed
the
bugfix/examples_override_path
branch
from
dbfea9a to
c96657a
Compare
This makes the example project usable from the component registry
This makes the example project usable from the component registry
This makes the 'target' example usable from the component registry. 'linux' example still has a bunch of EXTRA_COMPONENT_DIRS, but at least we can delete the protocol_examples_common copy.
This makes the example project usable from the component registry
By default, component manager expects that the examples are located under <component>/examples/<name>. Move mdns example so that it is found.
Remaining references to protocol_examples_common are replaced with references to ESP-IDF. We will later re-add protocol_examples_common or some equivalent of it under components/, and release it to the Component Registry.
david-cermak
force-pushed
the
bugfix/examples_override_path
branch
from
c96657a to
1ee9dae
Compare
gabsuren
approved these changes
Nov 9, 2023
|
Thanks for the quick review! CI is green -> merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes over #357 to pass the CI and complete integration
(please refer to the original PR for more info)