fix(modem): Fixed inconsistent state on data after OK #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we received response in two chunks and the first one completes the command (result=OK or FAIL), and the second chunk pre-empts command processing, then we performed processing again rewritting the result back to TIMEOUT. This would invalidate the command, but also causes an exception: ESP_MODEM_THROW_IF_ERROR(ESP_ERR_INVALID_STATE) Fixed by checking if the processing already finished in process_line(). Closes espressif#426
|
Thanks for this. Looks good. :) We run into this bug often due to URCs. Would definitely love to see it in the next release. |
euripedesrocha
approved these changes
Dec 6, 2023
|
Thanks for the review @dset0x @euripedesrocha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we received response in two chunks and the first one completed the command (result=OK or FAIL), and the second chunk preempts command processing, then we performed processing again rewriting the result back to TIMEOUT. This would invalidate the command, but also causes an exception:
ESP_MODEM_THROW_IF_ERROR(ESP_ERR_INVALID_STATE)Fixed by checking if the processing already finished in process_line().
Closes #426