Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: continuation after FIN in websocket client (#460) (IDFGH-11761) #461

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: continuation after FIN in websocket client (#460) (IDFGH-11761) #461

merged 1 commit into from
Dec 22, 2023

Conversation

0xFEEDC0DE64
Copy link
Contributor

Fixes #460

@0xFEEDC0DE64 0xFEEDC0DE64 mentioned this pull request Dec 19, 2023
Closed
3 tasks
david-cermak
david-cermak approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@david-cermak
Copy link
Collaborator

@gabsuren Please check if it's easier to revert fae80e2 or patch it as proposed here

@github-actions github-actions bot changed the title fix: continuation after FIN in websocket client (#460) fix: continuation after FIN in websocket client (#460) (IDFGH-11761) Dec 22, 2023
@gabsuren
Copy link
Contributor

@david-cermak this solution looks better to me. I will patch new release for it.
@0xFEEDC0DE64 thank you for noticing and fixing it.

@gabsuren gabsuren merged commit aadda22 into espressif:master Dec 22, 2023
69 checks passed
@espressif-bot espressif-bot assigned gabsuren and unassigned gabsuren Dec 22, 2023
@david-cermak david-cermak mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

@gabsuren gabsuren gabsuren approved these changes

Assignees

@gabsuren gabsuren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

websocket client decided to send first a FIN then a continuation, which is not allowed?! (IDFGH-11736)
4 participants
@0xFEEDC0DE64 @david-cermak @gabsuren @espressif-bot