Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): Fixed scripts for build test failure #483

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix(common): Fixed scripts for build test failure #483

merged 1 commit into from
Jan 16, 2024

Conversation

espressif-abhikroy
Copy link
Collaborator

Added changes to fix build test failures.

@espressif-abhikroy espressif-abhikroy force-pushed the ci/build_app_failure_fix branch 5 times, most recently from b7ffb84 to a56b4a0 Compare January 15, 2024 13:55
@espressif-abhikroy espressif-abhikroy self-assigned this Jan 15, 2024
@espressif-abhikroy espressif-abhikroy force-pushed the ci/build_app_failure_fix branch 2 times, most recently from 48fc7fe to 469c745 Compare January 15, 2024 14:05
@espressif-abhikroy espressif-abhikroy marked this pull request as ready for review January 15, 2024 15:04
david-cermak
david-cermak reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to fix the mdns tests.
LGTM otherwise

david-cermak
david-cermak approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@david-cermak david-cermak merged commit 585e4b3 into espressif:master Jan 16, 2024
123 checks passed
@espressif-abhikroy espressif-abhikroy deleted the ci/build_app_failure_fix branch January 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

@gabsuren gabsuren gabsuren approved these changes

Assignees

@espressif-abhikroy espressif-abhikroy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@espressif-abhikroy @gabsuren @david-cermak