fix(websocket): Continue waiting for TCP connection to be closed (IDFGH-11965) #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents an issue where WEBSOCKET_EVENT_CLOSED is not sent after websocket is closed.
|
|
github-actions
bot
changed the title
eht-datarespons
commented
Jan 26, 2024
… close within a reasonable amount of time.
|
@david-cermak Are there any other changes i should make or is the current state of the pull request acceptable? |
espressif-bot
assigned gabsuren and david-cermak and unassigned david-cermak and gabsuren
david-cermak
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was observed where the websocket client did not send WEBSOCKET_EVENT_CLOSED after server closed the websocket.
An alternative solution to fix the issue would be to remove the if instead. It could be more robust, but the existing comment seem to suggest that it was not the original intent.