-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mdns): Make including mdns_console KConfig (IDFGH-11988) #497
feat(mdns): Make including mdns_console KConfig (IDFGH-11988) #497
Conversation
The CLI that mdns_console offers is very useful for debugging and bootstrapping mDNS onto new projects, but some projects may not want console CLI in place to reduce binary size. This gives a KConfig option to do so.
@rretanubun do you see mdns_console contributing to binary size even when not calling mdns_console_register? (You can check with |
@igrr : No I do not, the linker does eliminate it. I was thinking adding an upstream supported KConfig option to allow projects to build with
then each sdkconfig variant controls if the project builds gets |
I agree with Ivan that this change won't affect the binary size, but may help reduce build time and since the console API is rarely used within mdns component I would tend to accept this PR, WYT @suren-gabrielyan-espressif ? The ultimate goal should migration of the mdns_console to other console components, cc @espressif-abhikroy |
@rretanubun Thanks for your contribution! |
The CLI that mdns_console offers is very useful for debugging and bootstrapping mDNS onto new projects, but some projects may not want console CLI in place to reduce binary size.
This gives a KConfig option to do so.