-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(websocket): Expanded example to demonstrate the transfer over TLS (IDFGH-11681) #506
Conversation
9d6c01b
to
a4ae7d9
Compare
58744a8
to
b7a49bc
Compare
1236708
to
3ea75a0
Compare
components/esp_websocket_client/examples/target/main/certs/client_csr.pem
Outdated
Show resolved
Hide resolved
components/esp_websocket_client/examples/target/main/certs/ca_cert.srl
Outdated
Show resolved
Hide resolved
components/esp_websocket_client/examples/target/sdkconfig.ci.tls_cert_not_required
Outdated
Show resolved
Hide resolved
As mentioned in the comments, I'd suggest using server side verification (always), optionally adding client side verification (mutual authentication). I think for user's perspective it would be useful to see these two additional configs:
|
3ea75a0
to
40fe2e1
Compare
@david-cermak thank you for the review.
Please let me know if this adjustment looks ok for you |
d5b1695
to
1717b1b
Compare
5b87169
to
3128d99
Compare
components/esp_websocket_client/examples/target/main/certs/ca_key.pem
Outdated
Show resolved
Hide resolved
components/esp_websocket_client/examples/target/main/Kconfig.projbuild
Outdated
Show resolved
Hide resolved
2195dd1
to
d7674f1
Compare
components/esp_websocket_client/examples/target/sdkconfig.ci.tls_servert_auth
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
2488889
to
565569e
Compare
565569e
to
0d0630e
Compare
No description provided.