New component esp_wifi_remote

[david-cermak]

Initial version

TODO

** This version **

• Add README and docs
• Cleanup git history
• new component stuff (changelog, versions)

** Next versions **

• Add APIs from esp_wifi_he.h
• Add cross-check that slave and host wifi config matches
• Add coexistence of the wifi_remote and wifi_native configurations

[CLAassistant]

All committers have signed the CLA.

[mantriyogesh]

private may create issues?

[david-cermak]

Thanks for pointing this out! I agree, I think we can remove it now (at least for the test to pass), but we should check with esp_hosted first.

[david-cermak]

We need to keep it as is, since we're using wifi netifs as esp_hosted channels. we need to use wifi_internal_ APIs for it.

[mantriyogesh]

Hello @david-cermak ,

I had reviewed the changes, looks fine. But let me test these and confirm.
Some small code changes I had to do while running, which I will attach as patch here..

[euripedesrocha]

Isn't better to set a base version?

[david-cermak]

I'll remove esp_hosted dependency for the initial version, but will add it later with more strict deps

[euripedesrocha]

Should we add a LOG stating that this is not supported?

[david-cermak]

I'll have to check where it is used. but will definitely add an error/debug log

[david-cermak]

This is still a shortcut at the moment, this API is called from netif layers and notifies wifi library that we got an IP.
I've added a TODO:... comment, that we need to transfer this info to the slave device and all esp_wifi_internal_set_sta_ip() there

[alisitsyn]

Left just minor comments.

[kostaond]

How it is handled when year changes?

[david-cermak]

I'll think about a better way and disscus offline

[david-cermak]

I kept the workflow, but added a description in the checker what to do and which file to update if it fails.

[david-cermak]

Hi guys, I've addressed most of the comments, could you please take another look and check mainly the unresolved discussions if it's okay with you? I likely won't be able to resolve it correctly with the initial version, though.

[mantriyogesh]

hosted_hooked_with_esp_wifi_remote.patch

[david-cermak]

hosted_hooked_with_esp_wifi_remote.patch

Thanks for sharing the patch. I've updated the PR accordingly and simplified the component a little:

• removed esp_wifi_remote_slave_init() altogether while making the channel operations public -- helps esp_hosted to implement it based on public channels
• defined most of the channel operations WEAK, so esp_hosted can update them
• made the minor modification and updates (logs, nullptr checks)

[david-cermak]

Thanks @euripedesrocha for the review. I'm taking the liberty of merging this now, I'll address the outstanding comments in the upcoming version. Thanks everyone for having a look!