-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(websocket): Support DS peripheral for mutual TLS (IDFGH-12285) #520
feat(websocket): Support DS peripheral for mutual TLS (IDFGH-12285) #520
Conversation
a5c52f9
to
6ada58d
Compare
@gabsuren Can you shed some light on this? Thanks! |
@johanstokking Thanks for implementing this useful feature. I've tested locally and it works as expected. I also think that we shouldn't add more configs and user options to the current example. It's already quite hard to follow for first-time users. Could you please make the following changes:
|
6ada58d
to
44d476f
Compare
@david-cermak I implemented your suggestions. I got myself briefly in the rabbit hole of rendering per-target documentation pages (to render the DS peripheral section conditionally on SOC_DIG_SIGN_SUPPORTED, like supported in esp-idf repo), but I have too little experience with this docs system to implement that properly. This is what the TLS section looks like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the updates (and those little fixes to the docs)!
sorry, hit edit instead of reply. wanted to say that we don't generate the docs for each target, only one static page. |
Fantastic project guys. Here's something I use that you might want to take into consideration: supporting the DS peripheral for mutual TLS.
Example usage with https://github.com/espressif/esp_secure_cert_mgr/:
I considered adding this to the example project, but I feel like it gets bloated quickly with dependencies and ifdefs.