fix(websocket): fix esp_event dependency management (IDFGH-12301) (IDFGH-12302) #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move esp_event from PRIV_REQUIRES to REQUIRES, as it is included by esp_websocket_client.h, so any code including that header also requires esp_event. This resolves the following build error for files not explicitly requiring esp_event: ninja: build stopped: subcommand failed. Compilation failed because esp_websocket_client.h (in "espressif__esp_websocket_client" component) includes esp_event.h, provided by esp_event component(s). However, esp_event component(s) is in the private requirements list of "espressif__esp_websocket_client". To fix this, move esp_event from PRIV_REQUIRES into REQUIRES list of idf_component_register call in ...\managed_components\espressif__esp_websocket_client\CMakeLists.txt. ninja failed with exit code 1, output of the command is in...
|
|
github-actions
bot
changed the title
github-actions
bot
changed the title
gabsuren
approved these changes
Mar 20, 2024
david-cermak
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move esp_event from PRIV_REQUIRES to REQUIRES, as it is included by esp_websocket_client.h, so any code including that header also requires esp_event.
This resolves the following build error for files not explicitly requiring esp_event:
ninja: build stopped: subcommand failed.
Compilation failed because esp_websocket_client.h (in "espressif__esp_websocket_client" component) includes esp_event.h, provided by esp_event component(s). However, esp_event component(s) is in the private requirements list of "espressif__esp_websocket_client". To fix this, move esp_event from PRIV_REQUIRES into REQUIRES list of idf_component_register call in ...\managed_components\espressif__esp_websocket_client\CMakeLists.txt. ninja failed with exit code 1, output of the command is in...