Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wifi remote]: Add example without esp_hosted #538

Merged
merged 4 commits into from
Apr 25, 2024
Merged

[wifi remote]: Add example without esp_hosted #538

merged 4 commits into from
Apr 25, 2024

Conversation

david-cermak
Copy link
Collaborator

@david-cermak david-cermak commented Mar 25, 2024 •
edited
Loading

Task list

  • Cleanup git history
  • Document and cleanup example README's
  • CI for examples
  • Bump the version of esp_wifi_remote

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@david-cermak david-cermak force-pushed the feat/wifi_remote_example branch 3 times, most recently from 773d0f3 to 9e73e4f Compare April 11, 2024 10:18
@david-cermak david-cermak self-assigned this Apr 11, 2024
@david-cermak david-cermak marked this pull request as ready for review April 11, 2024 10:21
@david-cermak david-cermak force-pushed the feat/wifi_remote_example branch from df53ca1 to e20eda6 Compare April 11, 2024 13:13
euripedesrocha
euripedesrocha reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@euripedesrocha euripedesrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

We have an empty file that might be a left over.

components/esp_wifi_remote/eppp/eppp_init.c Outdated Show resolved Hide resolved
components/esp_wifi_remote/eppp/eppp_init.c Outdated Show resolved Hide resolved
components/esp_wifi_remote/examples/mqtt/CMakeLists.txt Outdated Show resolved Hide resolved
components/esp_wifi_remote/eppp/wifi_remote_rpc_client.cpp Show resolved Hide resolved
components/esp_wifi_remote/eppp/wifi_remote_rpc_client.cpp Outdated Show resolved Hide resolved
components/esp_wifi_remote/eppp/wifi_remote_rpc_impl.hpp Outdated Show resolved Hide resolved
components/esp_wifi_remote/eppp/wifi_remote_rpc_impl.hpp Show resolved Hide resolved
@david-cermak david-cermak force-pushed the feat/wifi_remote_example branch from 837e5d7 to e6ab631 Compare April 19, 2024 08:04
@david-cermak david-cermak force-pushed the feat/wifi_remote_example branch from e04ed61 to 1a88dd3 Compare April 25, 2024 12:32
@david-cermak david-cermak force-pushed the feat/wifi_remote_example branch from 1a88dd3 to d163878 Compare April 25, 2024 13:14
@david-cermak david-cermak merged commit f032a9f into espressif:master Apr 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantriyogesh mantriyogesh mantriyogesh left review comments

@espressif-abhikroy espressif-abhikroy espressif-abhikroy approved these changes

@alisitsyn alisitsyn alisitsyn approved these changes

@gabsuren gabsuren gabsuren approved these changes

@euripedesrocha euripedesrocha euripedesrocha approved these changes

@kostaond kostaond Awaiting requested review from kostaond

Assignees

@david-cermak david-cermak

Labels
wifi_remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@david-cermak @CLAassistant @euripedesrocha @gabsuren @alisitsyn @mantriyogesh @espressif-abhikroy