Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(websocket): Fix locking issues of esp_websocket_client_send_with_exact_opcode IDF-9380 #550

Merged
merged 1 commit into from
May 17, 2024

Conversation

gabsuren
Copy link
Contributor

@gabsuren gabsuren commented Apr 12, 2024

  • Fix locking issues of esp_websocket_client_send_with_exact_opcode API
  • Extended examples to cover more cases
  • Added new config CONFIG_ESP_WS_CLIENT_ENABLE_DYNAMIC_BUFFER for testing
  • Added new target release-v5.2

@gabsuren gabsuren changed the title fix(websocket): Fix locking issues of `esp_websocket_client_send_with… fix(websocket): Fix locking issues of esp_websocket_client_send_with_exact_opcode IDF-9380 Apr 12, 2024
@gabsuren gabsuren force-pushed the fix_websokcet_params branch 4 times, most recently from e1f4093 to ddcc7f0 Compare April 16, 2024 10:14
@gabsuren gabsuren marked this pull request as ready for review April 16, 2024 10:16
@gabsuren gabsuren force-pushed the fix_websokcet_params branch from ddcc7f0 to e82c92c Compare April 16, 2024 16:03
@gabsuren gabsuren force-pushed the fix_websokcet_params branch 2 times, most recently from 659ffa9 to b07de63 Compare April 17, 2024 06:57
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some concerns on testing the binary APIs.

@gabsuren gabsuren force-pushed the fix_websokcet_params branch 3 times, most recently from c6a31f8 to 5ab762d Compare May 14, 2024 13:27
…_exact_opcode` API

Extended examples to cover more cases
Added new config CONFIG_ESP_WS_CLIENT_ENABLE_DYNAMIC_BUFFER for testing
@gabsuren gabsuren force-pushed the fix_websokcet_params branch from 5ab762d to 6393fcd Compare May 17, 2024 08:37
@gabsuren gabsuren merged commit ed021a9 into espressif:master May 17, 2024
46 of 48 checks passed
@gabsuren gabsuren deleted the fix_websokcet_params branch July 10, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants