Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(websocket): adding support for keep_alive_enable when using WSS transport (IDFGH-11457) #555

Merged
merged 1 commit into from
May 3, 2024

Conversation

gabsuren
Copy link
Contributor

No description provided.

@gabsuren gabsuren changed the title feat(websocket): adding support for keep_alive_enable when using WSS transport feat(websocket): adding support for keep_alive_enable when using WSS transport (IDFGH-11457) Apr 22, 2024
@gabsuren gabsuren requested a review from david-cermak April 22, 2024 07:01
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need a test for that?

@gabsuren
Copy link
Contributor Author

gabsuren commented Apr 26, 2024

LGTM, do we need a test for that?

TBH I am not sure, as the test should check the connection over a period of time, which can impact CI time

@gabsuren gabsuren merged commit d786f0d into espressif:master May 3, 2024
64 checks passed
@gabsuren gabsuren deleted the websocket_keep_alirve branch July 10, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants