Adds missing configuration fields #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some aspects of the underlying mqtt client were not set. Fix espressif#554
gabsuren
approved these changes
Apr 23, 2024
@gabsuren For which functions? |
Comment on lines
+136
to
+151
| mqtt_client_cfg.session.keepalive = config.session.keepalive; | ||
| mqtt_client_cfg.session.last_will.msg = config.session.last_will.lwt_msg; | ||
| mqtt_client_cfg.session.last_will.topic = config.session.last_will.lwt_topic; | ||
| mqtt_client_cfg.session.last_will.msg_len = config.session.last_will.lwt_msg_len; | ||
| mqtt_client_cfg.session.last_will.qos = config.session.last_will.lwt_qos; | ||
| mqtt_client_cfg.session.last_will.retain = config.session.last_will.lwt_retain; | ||
| mqtt_client_cfg.session.protocol_ver = config.session.protocol_ver; | ||
| mqtt_client_cfg.session.disable_keepalive = config.session.disable_keepalive; | ||
| mqtt_client_cfg.network.reconnect_timeout_ms = config.connection.reconnect_timeout_ms; | ||
| mqtt_client_cfg.network.timeout_ms = config.connection.network_timeout_ms; | ||
| mqtt_client_cfg.network.disable_auto_reconnect = config.connection.disable_auto_reconnect; | ||
| mqtt_client_cfg.network.refresh_connection_after_ms = config.connection.refresh_connection_after_ms; | ||
| mqtt_client_cfg.task.priority = config.task.task_prio; | ||
| mqtt_client_cfg.task.stack_size = config.task.task_stack; | ||
| mqtt_client_cfg.buffer.size = config.buffer_size; | ||
| mqtt_client_cfg.buffer.out_size = config.out_buffer_size; |
There was a problem hiding this comment.
could we use the visitor paradigm as for the broker options?
There was a problem hiding this comment.
something like: config_session(mqtt_client_cfg, config.session); ?
There was a problem hiding this comment.
Not exactly because here we have used the struct fields as is in the old mqtt client config struct. I'll do an update of the wrapper as a follow-up, but want to provide the fix first.
david-cermak
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some aspects of the underlying mqtt client were not set.