feat(mdns): add check of instance when handling PTR query (IDFGH-12701) #559
Conversation
github-actions
bot
changed the title
gytxxsy
force-pushed
the
feature/add_instance_check_for_existing_answer
branch
from
5818615 to
6af6ca5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| HOOK_MALLOC_FAILED; | ||
| goto clear_rx_packet; | ||
| } | ||
| memcpy(record->host, name->host, MDNS_NAME_BUF_LEN); |
Check warning
Code scanning / clang-tidy
Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning
| HOOK_MALLOC_FAILED; | ||
| goto clear_rx_packet; | ||
| } | ||
| memcpy(record->service, name->service, MDNS_NAME_BUF_LEN); |
Check warning
Code scanning / clang-tidy
Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning
| HOOK_MALLOC_FAILED; | ||
| goto clear_rx_packet; | ||
| } | ||
| memcpy(record->proto, name->proto, MDNS_NAME_BUF_LEN); |
Check warning
Code scanning / clang-tidy
Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning
Upon receiving a PTR query, when matching question and answer entries, if an instance exists in the answer entry, it will also be considered as one of the check items. This change is to avoid mistakenly deleting certain question entries. For example, if device A hosts services B with the different instances (ins1~ins5). When the device receives a PTR query, with the question querying service B, and the answer list already contains ins1.Service B and ins2.Service B, then when matching this question entry and answer entries, the question entry should not be deleted.
Check the answer entries in the query when creating answer entries for query response. If the answer entry already exists, then give up creating that entry.