Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI build per IDFv5.3 #560

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix CI build per IDFv5.3 #560

merged 3 commits into from
May 3, 2024

Conversation

david-cermak
Copy link
Collaborator

Fixes recent incompatibilities with latest IDF (v5.3)

  • Moving iperf out of IDF
  • ESP32P4 is supported target
  • warning: the choice symbol ETHERNET_PHY_... has no prompt

@david-cermak david-cermak self-assigned this Apr 26, 2024
@david-cermak
Copy link
Collaborator Author

@kostaond @bogdankolendovskyy

https://github.com/espressif/esp-eth-drivers/blob/2ca2628a54ec1d4c8c79d0f6e74a1e61f9fdb1e8/ethernet_init/Kconfig.projbuild#L67-L68

is causing build failures in with the latest IDF:

2024-04-26 11:51:38  WARNING [Post Build] >>> warning: default on the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) will have no effect, as defaults do not affect choice symbols
2024-04-26 11:51:38  WARNING [Post Build] >>> warning: the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) has no prompt
2024-04-26 11:51:38  WARNING [Post Build] >>> warning: default on the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) will have no effect, as defaults do not affect choice symbols
2024-04-26 11:51:38  WARNING [Post Build] >>> warning: the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) has no prompt

@kostaond
Copy link
Collaborator

kostaond commented May 3, 2024

@kostaond @bogdankolendovskyy

https://github.com/espressif/esp-eth-drivers/blob/2ca2628a54ec1d4c8c79d0f6e74a1e61f9fdb1e8/ethernet_init/Kconfig.projbuild#L67-L68

is causing build failures in with the latest IDF:

2024-04-26 11:51:38  WARNING [Post Build] >>> warning: default on the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) will have no effect, as defaults do not affect choice symbols
2024-04-26 11:51:38  WARNING [Post Build] >>> warning: the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) has no prompt
2024-04-26 11:51:38  WARNING [Post Build] >>> warning: default on the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) will have no effect, as defaults do not affect choice symbols
2024-04-26 11:51:38  WARNING [Post Build] >>> warning: the choice symbol ETHERNET_PHY_LAN867X (defined at /home/david/repos/protocols/components/console_cmd_ifconfig/examples/ifconfig-basic/managed_components/espressif__ethernet_init/Kconfig.projbuild:66) has no prompt

Should have been resolved by espressif/esp-eth-drivers#30

@david-cermak
Copy link
Collaborator Author

@kostaond Have reverted my fix and the pipeline failed again: https://github.com/espressif/esp-protocols/actions/runs/8937383020/job/24549536576?pr=560 -- have you bumped the version?

@david-cermak david-cermak merged commit f6f6ded into espressif:master May 3, 2024
163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euripedesrocha euripedesrocha euripedesrocha approved these changes

@espressif-abhikroy espressif-abhikroy Awaiting requested review from espressif-abhikroy

@kostaond kostaond Awaiting requested review from kostaond

@gabsuren gabsuren Awaiting requested review from gabsuren

Assignees

@david-cermak david-cermak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-cermak @kostaond @euripedesrocha