fix(mdns): remove same protocol services with different instances #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DejinChen
force-pushed
the
fix/remove_same_protocol_service
branch
from
1235c28 to
9f70e7e
Compare
DejinChen
force-pushed
the
fix/remove_same_protocol_service
branch
from
9f70e7e to
747eb3e
Compare
david-cermak
approved these changes
May 31, 2024
There was a problem hiding this comment.
LGTM, just please fix the CI.
@gabsuren can help you with the AFL host test, probably something missing on the mocking layer.
DejinChen
force-pushed
the
fix/remove_same_protocol_service
branch
from
747eb3e to
042533a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ESP-Matter may publish services with the same protocol and service type but different instance names. e.g., ''a.matter._tcp" and "b.matter._tcp". When service info changed, we have to remove all "matter._tcp" service through
mdns_service_remove(const char *service_type, const char *proto)and re-add new service. But now, the the different instance name services can not be removed at the same time. And re-adding will lead a memory leak problem for the unremoved services with the same subtype.Change overview: