[wifi-remote]: Fix server race when receiving command and posting events #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
fix/wifi_remote_server_sync
branch
from
30a5262 to
732b1d5
Compare
| ip_data = new (std::nothrow) esp_wifi_remote_eppp_ip_event; | ||
| return ip_data ? ESP_OK : ESP_ERR_NO_MEM; | ||
| } | ||
| ~Events() |
There was a problem hiding this comment.
Could you explain the usage you expect here? The struct has only default constructed data and depending on state the destructor might leak the allocated ip_data.
There was a problem hiding this comment.
The idea is using RAII even when en-queuing and later de-queuing the instance.
the destructor might leak the allocated ip_data.
- we construct
ip_dataonly when needed (if we get the appropriateIP_EVENT) - we put this instance to the queue and only after (successful) en-queuing we mark this as
DO-NOT-FREE, so the desctructor leaks the data, as they will be used afterwards... - we get the instance from the queue with the default state, so now the destructor frees the data as expected
(briefly commented here https://github.com/espressif/esp-protocols/pull/582/files#diff-e2d9eebe2ae3236f3c8b216ed4f69dd878089e5f7c1b2fe3fb9a23c238651b8fR61)
euripedesrocha
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race condition of simultaneously marshaling WiFi/IP event and receiving command from client.