[modem]: Add support for guessing mode #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
david-cermak
force-pushed
the
feat/modem_mode_detect
branch
2 times, most recently
from
85abac4 to
6f4231b
Compare
| return false; | ||
| } | ||
| mode = modem_mode::UNDEF; | ||
| ESP_LOGI("DCE mode", "Detected mode: %d", static_cast<int>(guessed)); |
There was a problem hiding this comment.
Do we need to log it in INFO mode? Could we move to DEBUG or VERBOSE?
| // Check whether the response resembles the "golden" reply (for these 3 protocols) | ||
| if (reply_pos >= sizeof(probe::ppp::lcp_echo_reply_head)) { | ||
| // check for initial 2 bytes | ||
| uint8_t *ptr = static_cast<uint8_t *>(memmem(reply, reply_pos, probe::ppp::lcp_echo_reply_head, 2)); |
There was a problem hiding this comment.
Build a string_view from the received buffer and use provided algorithms might lead to simpler code here.
There was a problem hiding this comment.
any idea how to do it without reinterpret cast?
std::string_view reply_view(reinterpret_cast<const char*>(reply), reply_size);
// Create a string_view for the bytes to compare against
std::string_view head_view(reinterpret_cast<const char*>(ppp::lcp_echo_reply_head.data()), 2);
// Check if the reply starts with the first 2 bytes of lcp_echo_reply_head
return reply_view.starts_with(head_view);There was a problem hiding this comment.
The thing is that I'm actually testing if the current protocol is binary or ascii, so I think the best option is to just use the old good memmem()...
3 tasks
david-cermak
force-pushed
the
feat/modem_mode_detect
branch
from
6f4231b to
de23a00
Compare
david-cermak
force-pushed
the
feat/modem_mode_detect
branch
from
de23a00 to
52598e5
Compare
euripedesrocha
approved these changes
Nov 6, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports only DATA and PPP mode
Add CMUX modes