Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdns]: send PTR query for mdns browse when interface is ready (IDFGH-13841) #661

Conversation

gytxxsy
Copy link
Contributor

@gytxxsy gytxxsy commented Sep 23, 2024

Description

When an interface changes from not ready to ready, a PTR query should be sent for all mdns browse on that interface.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed. (no functional change)
  • Tests are updated or added as necessary.(no functional change)
  • Git history is clean — commits are squashed to the minimum necessary.

@gytxxsy gytxxsy force-pushed the feat/monitor_interface_status_for_browsing branch from 2242437 to f50fc90 Compare September 23, 2024 10:05
@gytxxsy gytxxsy changed the title [mdns]: execute browse_send when interface is ready [mdns]: send PTR query for mdns browse when interface is ready Sep 23, 2024
@gytxxsy gytxxsy force-pushed the feat/monitor_interface_status_for_browsing branch from f50fc90 to 010a404 Compare September 23, 2024 11:01
@gytxxsy
Copy link
Contributor Author

gytxxsy commented Oct 9, 2024

@david-cermak Could you please take a look of this PR?

@github-actions github-actions bot changed the title [mdns]: send PTR query for mdns browse when interface is ready [mdns]: send PTR query for mdns browse when interface is ready (IDFGH-13841) Oct 9, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 9, 2024
@david-cermak
Copy link
Collaborator

@gytxxsy this task has been masked as done:

* Tests are updated or added as necessary.

but saw no changes to the test code. Does it mean that these changes don't have to be tested?

@gytxxsy
Copy link
Contributor Author

gytxxsy commented Oct 25, 2024

@gytxxsy this task has been masked as done:

* Tests are updated or added as necessary.

but saw no changes to the test code. Does it mean that these changes don't have to be tested?

@david-cermak This PR is considered a fix for the existing functionality (referencing avahi's behavior) rather than adding new features, so I think it's not necessary to add new test cases.

@david-cermak
Copy link
Collaborator

@gytxxsy this task has been masked as done:

* Tests are updated or added as necessary.

but saw no changes to the test code. Does it mean that these changes don't have to be tested?

@david-cermak This PR is considered a fix for the existing functionality (referencing avahi's behavior) rather than adding new features, so I think it's not necessary to add new test cases.

Thanks for explaining! LGTM!

@david-cermak david-cermak merged commit fbd296f into espressif:master Oct 25, 2024
102 checks passed
@gytxxsy
Copy link
Contributor Author

gytxxsy commented Nov 13, 2024

@david-cermak
Do you have any plans to bump the version soon? I think this PR is a meaningful fix and needs to be included in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants