Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket): fix example buffer leak #686

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(websocket): fix example buffer leak #686

merged 1 commit into from
Nov 5, 2024

Conversation

bryghtlabs-richard
Copy link
Contributor

Description

Free allocated buffer in websocket client example application to balance heap-trace.

Testing

TODO: in-progress

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

david-cermak
david-cermak approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@david-cermak david-cermak merged commit 0b5e362 into espressif:master Nov 5, 2024
74 checks passed
@bryghtlabs-richard bryghtlabs-richard deleted the fix/wsExampleLeak branch November 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

Assignees
No one assigned
Labels
websocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryghtlabs-richard @david-cermak