Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(websocket) tidy up two small issues #714

Merged

Conversation

bryghtlabs-richard
Copy link
Contributor

Description

Remove an unused structure member and realign another. This makes the code easier to work on when working with reconnection.

Testing

WebSocket client was compiled and connected to server many times.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@david-cermak david-cermak merged commit 42cde46 into espressif:master Dec 17, 2024
82 checks passed
@bryghtlabs-richard bryghtlabs-richard deleted the chore/websocketTidying branch December 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants