Skip to content

Commit

Permalink
Merge branch 'fix/fix_caps_compatibility_isuue' into 'main'
Browse files Browse the repository at this point in the history
fix(br): register a compatibility error handler for border router

See merge request espressif/esp-thread-br!144
  • Loading branch information
chshu committed Nov 19, 2024
2 parents 255cb23 + ccf5b28 commit 6f1f618
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ static void ot_task_worker(void *ctx)

// Initialize the OpenThread stack
esp_openthread_register_rcp_failure_handler(rcp_failure_handler);
esp_openthread_set_compatibility_error_callback(rcp_failure_handler);
ESP_ERROR_CHECK(esp_openthread_init(&s_openthread_platform_config));
#if CONFIG_AUTO_UPDATE_RCP
try_update_ot_rcp(&s_openthread_platform_config);
Expand Down

2 comments on commit 6f1f618

@L1nC0Ln-A
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esp-thread-br-main/examples/common/thread_border_router/src/border_router_launch.c: In function 'ot_task_worker':
esp-thread-br-main/examples/common/thread_border_router/src/border_router_launch.c:164:5: error: implicit declaration of function 'esp_openthread_set_compatibility_error_callback' [-Werror=implicit-function-declaration]
164 | esp_openthread_set_compatibility_error_callback(rcp_failure_handler);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@gytxxsy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esp-thread-br-main/examples/common/thread_border_router/src/border_router_launch.c: In function 'ot_task_worker': esp-thread-br-main/examples/common/thread_border_router/src/border_router_launch.c:164:5: error: implicit declaration of function 'esp_openthread_set_compatibility_error_callback' [-Werror=implicit-function-declaration] 164 | esp_openthread_set_compatibility_error_callback(rcp_failure_handler); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This PR is to properly handle rcp compatibility errors. Please update the esp-idf to the master which contains this commit espressif/esp-idf@f41b43d

Please sign in to comment.